Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7179 use weight windows file in new simulation #7321

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Conversation

moellep
Copy link
Member

@moellep moellep commented Oct 18, 2024

also fix #1755 resizing browser window now correctly updates 3d plot axes
also fix #6325 incorrect axis swap

@moellep moellep requested a review from e-carlin October 18, 2024 17:44
@moellep
Copy link
Member Author

moellep commented Oct 18, 2024

@e-carlin the change to the openmc app was to allow the weight-windows output file to be saved after running a variance reduction sim. There is also an option to save the weight-windows file to the user's lib directory and use that file when running a new simulation. It does this by saving the weight-windows file as a sim_file after the simulation completes (which I think brings it back from the remote (sbatch) to the local server). That sim_file is then available to copy into the lib dir if the user requests it. I tested on dev with a local sbatch and it seems to work ok.

To test it, use the Tokamak Reactor example, then set the Variance Reduction parameters on the Visualization page:

x

Then run the sim, and the weight windows download link and button will appear on the simulation status:

x2

When you select the "Apply Weight Windows" it will show a confirmation page, and then copy the sim file to the lib and set up the simulation for running with that lib file.

Copy link
Member

@e-carlin e-carlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Left two comments about the structure.

sirepo/template/openmc.py Outdated Show resolved Hide resolved
sirepo/template/openmc.py Show resolved Hide resolved
@moellep moellep enabled auto-merge (squash) October 21, 2024 17:53
@moellep moellep merged commit 79725ca into master Oct 21, 2024
3 checks passed
@moellep moellep deleted the 7179-ww-input branch October 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axis is swapping direction depending on orientation warpvnd: resize browser doesn't update 3d axis labels
2 participants