Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] upgrade eclipse-temurin from version 20 to 21 #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gronke
Copy link
Contributor

@gronke gronke commented Nov 20, 2024

Upgrade docbuilder runtime eclipse-temurin from version 20 to 21.

@gronke gronke requested a review from a team as a code owner November 20, 2024 22:16
@PeterMosmans
Copy link

PeterMosmans commented Nov 21, 2024

FYI it makes sense to add automated tests, to ensure stuff still builds after upgrades. Locally I do a testbuild by cloning the pentext repo, and then performing a "report" build, something like:

clone: # Clone PenText to a new directory
	git clone https://github.com/radicallyopensecurity/pentext clone

sample:
	@echo "Creating sample report..." && \
	mkdir -p settings && \
	cp -r sample-report/graphics/* graphics/ && \
	cp -r sample-report/source/* source/

fulltest: clone # Create and build a sample report
	@cp Makefile clone/Makefile && \
	mkdir -p clone/settings && \
	cp settings/fop.conf clone/settings/ && \
	make --silent -C clone clean && \
	make --silent -C clone sample && \
	make --silent -C clone report

I can add a PR for this, but... I personally use a different Makefile (as I'm not using this repo, but I have my own toolchain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants