Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with setup script, pdf generation script and fixed some typo bugs #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Einzelganger
Copy link
Contributor

I decided to take a look at the project and tried running things. The manual Saxon and FOP commands for creating a PDF file from an XML file could be scripted, so I created a script for that. Also created a script for Linux to install Saxon, Java, jEdit, FOP and the fonts.
Today I found out that some rework has been done, so instead of downloading the fonts, I used the ones in the rosbot dir. That was missing one font, so added that. The example report also had some typos to external xml(s) sheets. Fixed that as well. Updated the Tools manual too.

@PeterMosmans
Copy link
Contributor

Hi @Einzelganger , thanks for the pull request, much appreciated!

Would it be possible to generate separate pull requests per commit ? This will make it easier to merge / check.
Furthermore - the master branch will be merged with an internal feature branch soon (read: within the next week), which means that you (unfortunately) have to rebase (again).
See https://github.com/radicallyopensecurity/docbuilder where current (Python) build and validation scripts reside.

Thanks once again!

Peter

@Einzelganger
Copy link
Contributor Author

Hi @PeterMosmans ,

You're welcome. I saw that you were also working on a docbuilder script, but it didn't seem to work as I tested it over a week ago. I decided to brush up on Bash scripting and create my own script, but next time I might just improve yours instead. Mine looks quite messy in comparison. :-) That and Python is of course cross-platform, so it beats Bash. I see that you don't auto-update the PDF (looking at the code), that could be a feature to add. Mine uses a timer to auto-update, but if you use an MD5 checksum to test if the source XML file changed, that also seems like an option. Still wanted to add it to my script in the future.

I can try creating per-commit pull requests, but since I commit very often I hope that sending dozens of pull requests doesn't make things incomprehensible in another way.
Maybe sending pull requests per-changed-file would also be a good idea? Or is per commit still better and the standard within the company?
Thanks for the heads-up on the upcoming changes.

regards,
Deborah

@PeterMosmans
Copy link
Contributor

Hi @Einzelganger ,

Sorry for the confusion - I meant one pull request per 'feature', not per commit (although in an ideal, rebased world, each feature equals one commit 😉 ). Committing often and early is 👍

I'll keep you up to date with regards to the merge.

Cheers,

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants