add documentation for reading lower-dimensional objects #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 77.87% 78.17% +0.30%
==========================================
Files 24 24
Lines 5863 5921 +58
==========================================
+ Hits 4566 4629 +63
+ Misses 1297 1292 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e-koch
reviewed
Aug 7, 2022
Co-authored-by: Eric Koch <[email protected]>
Co-authored-by: Eric Koch <[email protected]>
Co-authored-by: Eric Koch <[email protected]>
Co-authored-by: Eric Koch <[email protected]>
Co-authored-by: Eric Koch <[email protected]>
keflavich
commented
Aug 7, 2022
keflavich
commented
Aug 7, 2022
|
This probably ought to be squashed on merge because of all the gh-suggest commits |
e-koch
approved these changes
Aug 7, 2022
|
afaict, the error is unrelated. I'm gonna merge and hope the windows-based, dask-test error just goes away... |
keflavich
added a commit
to keflavich/spectral-cube
that referenced
this pull request
Aug 24, 2022
…tools#834) * add documentation for reading lower-dimensional objects * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]>
keflavich
added a commit
to keflavich/spectral-cube
that referenced
this pull request
Aug 24, 2022
…tools#834) * add documentation for reading lower-dimensional objects * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]>
keflavich
pushed a commit
to keflavich/spectral-cube
that referenced
this pull request
Sep 23, 2022
author SpacialTree <[email protected]> 1658337021 -0400 committer Adam Ginsburg (keflavich) <[email protected]> 1663972401 -0400 Add cube mosaicking Created functions to mosaic cubes together. Made Requested Changes to Pull Request Delete .gitignore Revert "Delete .gitignore" This reverts commit 04ccb30. Update .gitignore Fix for Colorbar already exists error In the case where the FITSFigure has already has a colorbar, will not attempt to add the colorbar again. Catch all Exceptions for Quicklook Should print out all exceptions when encountering them in quicklook, and display an image still instead of crashing. Change to Combine Headers Rename `reproject_together` and change function to use headers instead of cubes. mosaic_cubes now takes a list Rework of mosaic_cubes to take a list of cubes and mosaic them all together into the same field. Update cube_utils.py Change function name to combine_headers where it was called Update combine_headers Fixed problems with find_optimal_celestial_wcs line being passed 3D WCS and wrong order of WCS & shape Update cube_utils.py Fixed masking out additional cubes Update test_regrid.py Added test for mosaic_cubes Update cube_utils.py Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update cube_utils.py += was causing an error Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update lower_dimensional_structures.py Update test_regrid.py add import statement Update test_regrid.py more specific import statement Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py block size argument error Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> pass kwargs to reproject add documentation for reading lower-dimensional objects (radio-astro-tools#834) * add documentation for reading lower-dimensional objects * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> fix some simple issues fix up first part of test (testing WCS) remove comments minor whitespace Fix whitespace Fix for missing edges Add fix to other reproject pass kwargs to mosaic_cubes
keflavich
pushed a commit
to keflavich/spectral-cube
that referenced
this pull request
Sep 28, 2022
author SpacialTree <[email protected]> 1658337021 -0400 committer Adam Ginsburg (keflavich) <[email protected]> 1663972401 -0400 Add cube mosaicking Created functions to mosaic cubes together. Made Requested Changes to Pull Request Delete .gitignore Revert "Delete .gitignore" This reverts commit 04ccb30. Update .gitignore Fix for Colorbar already exists error In the case where the FITSFigure has already has a colorbar, will not attempt to add the colorbar again. Catch all Exceptions for Quicklook Should print out all exceptions when encountering them in quicklook, and display an image still instead of crashing. Change to Combine Headers Rename `reproject_together` and change function to use headers instead of cubes. mosaic_cubes now takes a list Rework of mosaic_cubes to take a list of cubes and mosaic them all together into the same field. Update cube_utils.py Change function name to combine_headers where it was called Update combine_headers Fixed problems with find_optimal_celestial_wcs line being passed 3D WCS and wrong order of WCS & shape Update cube_utils.py Fixed masking out additional cubes Update test_regrid.py Added test for mosaic_cubes Update cube_utils.py Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> Update cube_utils.py += was causing an error Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update lower_dimensional_structures.py Update test_regrid.py add import statement Update test_regrid.py more specific import statement Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/cube_utils.py block size argument error Co-authored-by: Adam Ginsburg <[email protected]> Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> pass kwargs to reproject add documentation for reading lower-dimensional objects (radio-astro-tools#834) * add documentation for reading lower-dimensional objects * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> fix some simple issues fix up first part of test (testing WCS) remove comments minor whitespace Fix whitespace Fix for missing edges Add fix to other reproject pass kwargs to mosaic_cubes
keflavich
added a commit
that referenced
this pull request
Oct 4, 2022
* Add cube mosaicking Created functions to mosaic cubes together. * Made Requested Changes to Pull Request * Delete .gitignore * Revert "Delete .gitignore" This reverts commit 04ccb30. * Update .gitignore * Fix for Colorbar already exists error In the case where the FITSFigure has already has a colorbar, will not attempt to add the colorbar again. * Catch all Exceptions for Quicklook Should print out all exceptions when encountering them in quicklook, and display an image still instead of crashing. * Change to Combine Headers Rename `reproject_together` and change function to use headers instead of cubes. * mosaic_cubes now takes a list Rework of mosaic_cubes to take a list of cubes and mosaic them all together into the same field. * Update cube_utils.py Change function name to combine_headers where it was called * Update combine_headers Fixed problems with find_optimal_celestial_wcs line being passed 3D WCS and wrong order of WCS & shape * Update cube_utils.py Fixed masking out additional cubes * Update test_regrid.py Added test for mosaic_cubes * Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/cube_utils.py Co-authored-by: Adam Ginsburg <[email protected]> * Update cube_utils.py * Update cube_utils.py += was causing an error * Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> * Update lower_dimensional_structures.py * Update test_regrid.py add import statement * Update test_regrid.py more specific import statement * Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/cube_utils.py block size argument error Co-authored-by: Adam Ginsburg <[email protected]> * Update spectral_cube/tests/test_regrid.py Co-authored-by: Adam Ginsburg <[email protected]> * pass kwargs to reproject * add documentation for reading lower-dimensional objects (#834) * add documentation for reading lower-dimensional objects * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update docs/creating_reading.rst Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/lower_dimensional_structures.py Co-authored-by: Eric Koch <[email protected]> * fix some simple issues * fix up first part of test (testing WCS) * remove comments * minor whitespace * Fix whitespace * Fix for missing edges * Add fix to other reproject * pass kwargs to mosaic_cubes * fix tests and add some helpful error messages * fix bug uncovered with new test * Update spectral_cube/tests/test_regrid.py Co-authored-by: Eric Koch <[email protected]> * Update spectral_cube/cube_utils.py Co-authored-by: Eric Koch <[email protected]> * resolve comment from e-koch * minor flake8 fixes Co-authored-by: Adam Ginsburg <[email protected]> Co-authored-by: Eric Koch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #833
I smuggled in a configuration item -
ext=0is now a keyword arg instead of hard-coding it.