Timestream high pass filter #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrs65
commented
Aug 22, 2023
jrs65
commented
- feat(containers): add DataWeightContainer to abstract over generic inputs
- feat(containers): add VisBase as a very generic container for visibilities
- feat(HPFTimeStream): high pass filter a generic timestream
rikvl
reviewed
Aug 24, 2023
| Implicitly pad the timestream with this many multiples of tau worth of zeros. | ||
| This is used to mitigate edge effects. The default is 2. | ||
| window | ||
| Use a Blackman window when determining the low-pass filtered timestream. When |
There was a problem hiding this comment.
Suggested change
| Use a Blackman window when determining the low-pass filtered timestream. When | |
| Use a Blackman window when determining the high-pass filtered timestream. When |
Not sure if this is a typo or if I misunderstand something
draco/core/containers.py
Outdated
| @property | ||
| def weight(self) -> memh5.MemDataset: | ||
| """The weights for each data point.""" | ||
| if not self._weight_name: |
There was a problem hiding this comment.
Suggested change
| if not self._weight_name: | |
| if not self._weight_dset_name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.