Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection from index map values #297

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Oct 22, 2024

Adds the ability for SelectionsMixin to make selections based on index_map entries. This has to be explicitly enabled with the allow_index_map attribute, and will raise an error if an item is not found in the index map.

@ljgray ljgray requested a review from ssiegelx October 22, 2024 22:14
draco/analysis/transform.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ssiegelx ssiegelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ljgray ljgray merged commit 7bdd270 into master Oct 23, 2024
4 checks passed
@ljgray ljgray deleted the ljg/index-map-select branch October 23, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants