Telescope class using externally-defined beam model #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd forgotten that this relies on beam model containers from Until we decide what to do, I've converted this into a draft. |
…r HEALPixBeam The beam dataset in HEALPixBeam is a structured np.dtype that can't pass the np.issubclass_ check. This patch extracts and checks the types of the dtype fields explicitly. This issue was noticed in ch_pipeline and fixed by Alex Reda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports existing code in
ch_pipelineover todriftscan, so that we can perform simulations for non-CHIME telescopes with arbitrary primary beam models.I've also resolved an annoying complex-to-real conversion warning in the power spectrum estimation code.