Segmented control: fix indicator box shadow regression #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chaance
approved these changes
Dec 31, 2024
chaance
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regression introduced in #621 where all segmented control indicators (both classic and surface variants) lost their box shadow styles. For disabled controls, there should be no box shadow on the indicator control. The CSS wasn't treating the indicator as a sibling of the item.
Disabled styles
Active styles
Testing steps
Visit the playground, check that both the classic and surface variant has the correct box shadow on the
::beforepseudoselecter for active controls.Relates issues / PRs