Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.: keep import called lib consistent with radon #120 #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hustjieke
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #138 (3336385) into master (bfa9c07) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #138   +/-   ##
=====================================
- Coverage      68%    68%   -1%     
=====================================
  Files          48     48           
  Lines        3734   3734           
=====================================
- Hits         2544   2541    -3     
- Misses        958    960    +2     
- Partials      232    233    +1     
Impacted Files Coverage Δ
src/mysql/api.go 61% <ø> (ø)
src/mysql/attr.go 100% <ø> (ø)
src/mysql/db.go 88% <ø> (ø)
src/mysql/mock.go 21% <ø> (ø)
src/mysql/mysql.go 66% <ø> (ø)
src/mysql/mysql_handler.go 71% <ø> (ø)
src/mysql/mysqlbase.go 86% <ø> (ø)
src/mysql/stats.go 100% <ø> (ø)
src/mysqld/backup.go 82% <ø> (ø)
src/mysqld/linux_args.go 100% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa9c07...3336385. Read the comment docs.

[summary]
import lib order like:
import (
	"system lib1"
	"system lib2"
	...

	"github.com/....1"
	"github.com/....2"
	...
)

[test case]
N/A

[patch codecov]
N/A
@hustjieke hustjieke force-pushed the feature_keep_import_called_lib_consitent_with_radon_#120 branch from 6300e23 to 3336385 Compare June 22, 2021 07:05
@hustjieke hustjieke marked this pull request as ready for review June 22, 2021 07:13
@dbkernel
Copy link
Contributor

LGTM

1 similar comment
@zhyass
Copy link
Contributor

zhyass commented Jul 9, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants