This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Fix: top panel hidden after fullscreen/maximized client #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #169 and #160.
request::unmanage is at fault, it's not being emitted when we desire to return the top panel back.
From docs:
request::manage Emitted when a new client appears and gets managed by Awesome.
What we would much rather desire is:
unfocus Emitted when a client gets unfocused.
We don't have to worry about getting panel when going from fullscreen to fullscreen on another workspace, as this case will trigger add_top_panel and then remove_top_panel sequentially.