Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass schedules to emailer cronjobs from values.yaml #1263

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Redande
Copy link
Contributor

@Redande Redande commented Jun 6, 2024

We want to run prague and purkyne emailers multiple times a year, but the dates vary too much for cronjob's schedule syntax. Added the dates to values.yaml so that we can run the same template multiple times a year, and to easily modify when to run them.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (45b3ffb) to head (a4258df).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1263   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files         144      144           
  Lines        6042     6042           
  Branches     1434     1434           
=======================================
  Hits         4014     4014           
  Misses       1889     1889           
  Partials      139      139           
Flag Coverage Δ
backend 66.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Redande Redande merged commit b0e7011 into master Jun 6, 2024
6 checks passed
@Redande Redande deleted the pass-schedules-to-mailer-cronjobs-from-values branch June 6, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant