Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats emailer cronjobs #1265

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix stats emailer cronjobs #1265

merged 1 commit into from
Aug 27, 2024

Conversation

Redande
Copy link
Contributor

@Redande Redande commented Aug 27, 2024

Multiple cronjobs are generated from values.yaml. They had identical name so only the last one was created, this PR gives unique names to the cronjobs based on the id defined in values.yaml. This should allow for multiple cronjobs from the same template (with differing schedules).

@Redande Redande merged commit 4130c2d into master Aug 27, 2024
4 checks passed
@Redande Redande deleted the fix-stats-emailer-cronjobs branch August 27, 2024 16:01
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (bb98b52) to head (f4bbf92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files         144      144           
  Lines        6042     6042           
  Branches     1434     1434           
=======================================
  Hits         4014     4014           
  Misses       1889     1889           
  Partials      139      139           
Flag Coverage Δ
backend 66.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant