Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer review accepting threshold is disabled if accepting strategy is manual review everything #1206

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Peer review accepting threshold is disabled if accepting strategy is manual review everything #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d40b85
Peer review accepting threshold is disabled if accepting strategy is …
Nov 22, 2023
d3a0960
test fix
Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions services/cms/src/components/PeerReviewEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,10 @@ const PeerReviewEditor: React.FC<PeerReviewEditorProps> = ({
step="0.01"
min={0}
required
disabled={
parsedPeerReviewConfig.accepting_strategy.toString() ===
"ManualReviewEverything"
}
value={parsedPeerReviewConfig.accepting_threshold}
onChangeByValue={(value) => {
handlePeerReviewValueChange(value, "accepting_threshold")
Expand Down
4 changes: 0 additions & 4 deletions system-tests/src/tests/peer-reviews/peer-review-editor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ test("default peer review editing", async ({ page, headless }, testInfo) => {
)
.selectOption("ManualReviewEverything")

await page1.locator('input[type="number"]').nth(2).click()
// Fill input[type="number"] >> nth=2
await page1.locator('input[type="number"]').nth(2).fill("2.5")

await page1.getByRole("button", { name: "Delete" }).nth(1).click()
// Fill text=General comments
await page1.locator("text=General comments").fill("test")
Expand Down
Loading