Expandable content -block #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 16, 2024 11:44
george-misan
approved these changes
Oct 10, 2024
nygrenh
requested changes
Oct 15, 2024
| editing={false} | ||
| selectedBlockId={null} | ||
| setEdits={function (): void { | ||
| throw new Error("Function not implemented.") |
There was a problem hiding this comment.
Check out if this crashes the frontend
| const InnerCardBlock: React.FC<React.PropsWithChildren<BlockRendererProps<FlipCardAttributes>>> = ( | ||
| props, | ||
| ) => { | ||
| if (isBlockImage(props.data.innerBlocks[0]) && props.data.innerBlocks.length == 1) { |
There was a problem hiding this comment.
Add a comment for explaining the if
There was a problem hiding this comment.
Does it crash if innerblocks is empty?
| transition: transform 0.8s; | ||
| transform-style: preserve-3d; | ||
| ${frontSideUp ? "transform: rotateY(180deg);" : "transform: rotateY(0);"} | ||
| ${currentIsImage ? "" : "border: 3px solid #bfbec6"}; |
There was a problem hiding this comment.
Suggested change
| ${currentIsImage ? "" : "border: 3px solid #bfbec6"}; | |
| ${!currentIsImage && "border: 3px solid #bfbec6;"} |
| const frontCard = props.data.innerBlocks[0] as Block<FlipCardAttributes> | ||
| const backCard = props.data.innerBlocks[1] as Block<FlipCardAttributes> | ||
|
|
||
| let size = 0 |
There was a problem hiding this comment.
create a function in this file sizeStringToSizePx
| const { t } = useTranslation() | ||
| const frontCard = props.data.innerBlocks[0] as Block<FlipCardAttributes> | ||
| const backCard = props.data.innerBlocks[1] as Block<FlipCardAttributes> | ||
|
|
There was a problem hiding this comment.
Check if frontCard and backcard are defined and return an error banner if they are not.
| @@ -0,0 +1,56 @@ | |||
| /* eslint-disable i18next/no-literal-string */ | |||
There was a problem hiding this comment.
Don't need to ignore the whole file
nygrenh
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.