Rip 149 dm ux improvements #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scottrepreneur
commented
Nov 2, 2023
•
scottrepreneur
commented
- Add clarification to counts on the several pages
- Change default member view to "actively raiding"
- Remove Dashboard heading on /
- Change "Add Role" to "Add Role Required" dropdown copy. stack if buttons too wide.
- Copy Raid ID button
- Clean up width/truncate (to number of lines with Chakra)
- Show Project Specs when no link is available. provide default "partial" line 108 of RaidDetailsCard.tsx
- InfoStack with link is different size/font to text infos
- Min Width on Consultation/Raid Details section(s)
- Specs value is missing or missing NA option
- Better status update layout
- Hide nav links unless logged in
Change default Member Status filter from "Show All" to "Is Raiding"
Modified button text for clarity.
Fixes the previous implementation of Copy in InfoStack, which was not
clickable.
The workaround for truncating the Raid ID in RaidDetailsCard was the
following snippet using minWidth, which could probably be done better.
<Stack justify='center' minWidth={'0.5'}>
Also addresses "Specs value is missing or missing NA option"
Fix: `InfoStack` with link is different size/font to text infos
Also solves a bug where revealed status updates could overflow the width of the container. Called "Better status update layout" in RIP 149 notes
43 tasks
43 tasks
# Conflicts: # libs/dm-hooks/src/useEscrowZap.ts
# Conflicts: # apps/frontend/components/InfoStack.tsx
scottrepreneur
force-pushed
the
rip-149-dm-ux-improvements
branch
from
0d8b736 to
6923e10
Compare
This was
linked to
issues
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.