Skip to content

Commit

Permalink
Add test:arel to test separately from adapters
Browse files Browse the repository at this point in the history
Previously, all of the Arel tests would be run with every database
adapter. This is not necessarily a problem, but these tests end up
running redundantly for each adapter/database combination even though
they do not interact with adapters at all.

This commit follows up a commit in Rails [1] that added a new test:arel
task for Active Record. This additional step creates a place for Arel to
be tested a single time, so that a followup PR to Rails can filter out
Arel tests when testing adapters.

Since the task is only present on the main branch, it cannot run for all
Rails versions and must be a special case.

[1] rails/rails@f362f07
  • Loading branch information
skipkayhil committed Mar 3, 2023
1 parent b3bc915 commit 8d94ec8
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pipeline-generate
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ end
if REPO_ROOT.join("actionview/Rakefile").read.include?("task :ujs")
step_for("actionview", "test:ujs", service: "actionview")
end
if REPO_ROOT.join("activerecord/Rakefile").read.include?("Rake::TestTask(:arel)")
# Added during 7.1 development on main
step_for("activerecord", "test:arel", service: "default")
end
steps_for("activejob", "test:integration", service: "activejob") do |x|
# Enable soft_fail until the problem in queue_classic is solved.
# https://github.com/rails/rails/pull/37517#issuecomment-545370408
Expand Down

0 comments on commit 8d94ec8

Please sign in to comment.