Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespacing directory generation fix #380

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nullset2
Copy link

@nullset2 nullset2 commented Feb 6, 2017

See issue #379. Very quick contribution, the tests pass afaik, I used gsub on the templates because using that we'll avoid breaking the templates for un-namespaced scaffolding. I know there's probably a better way to do this but I think this is still usable though.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rwz (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nullset2 nullset2 force-pushed the namespacing-directory-generation-fix branch from 5eab3af to 1e1778c Compare February 6, 2017 02:55
@nullset2
Copy link
Author

Hey guys, sorry about dropping off this PR a while ago, I got stuck with a lot of stuff and I'm trying to pick it up now.

The checks pass now and I think I have described the problem adequately and my approach works, however I'm willing to change stuff if you have feedback for me.

Thanks dudes.

assert_match %r{json\.extract! api_foo, :id, :bar, :baz, :created_at, :updated_at}, content
assert_match %r{json\.url api_foo_url\(api_foo, format: :json\)}, content
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove those blank lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the lines after 34 on the test?

@nullset2
Copy link
Author

nullset2 commented Jul 9, 2017

@rafaelfranca do you have any additional input for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants