Test installer commands (retry) #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds testing infrastructure to test against multiple versions of Rails, including Rails `main` branch.
This adds test coverage for the shared behavior of the installer commands. The commands are tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installers can be tested with different versions of Rails in CI.
This adds test coverage for specific behavior of the `javascript:install:bun` command.
This adds test coverage for specific behavior of the `javascript:install:esbuild` command.
This adds test coverage for specific behavior of the `javascript:install:rollup` command.
This adds test coverage for specific behavior of the `javascript:install:webpack` command.
|
That worked! |
|
Could you add a bin/test binstub as well to trigger this? And maybe we should also get some github hooks setup to run automatically on PRs. |
Do you mean a binstub to run
The GitHub workflow from this PR will trigger on PRs: Or did you mean something else? |
|
Was thinking that bin/test should run everything. Ahh, hadn't noticed that on the ci.yml. All good then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a retry of #182. I have added a gemfile for Rails 6.1, and refreshed all gemfile lock files.
@dhh I did not track down the root cause of the messages in #196 (comment), but they only appear when testing with Rails 6.0. Currently,
mainbranch tests with Rail 6.1 by default. In #182, I had changed that to Rails 6.0 to match the gemspec, but I have changed it back to Rails 6.1 in this PR.In summary, after this PR is merged: the gemspec will require Rails >= 6.0,
bundle exec rakewill test with Rails 6.1, and CI will test with Rails >= 6.1.