Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include? to list, uniquelist #148

Closed
wants to merge 2 commits into from

Conversation

heka1024
Copy link
Contributor

@heka1024 heka1024 commented Mar 8, 2024

Motivation

  • Support include? method for Kredis::Types::List

Modification

Result

  • Users can use include? without load members of list to memory

heka1024 added 2 commits March 8, 2024 16:00
- Support `include?` method for `Kredis::Types::List`

# Modification
- Allow `List` to proxy `lpos` (refer: https://redis.io/commands/lpos/)

# Result
- Users can use `include?` without load members of list to memory
@heka1024 heka1024 changed the title Add include? to list Add include? to list, uniquelist Mar 8, 2024
@heka1024 heka1024 closed this Mar 8, 2024
@heka1024
Copy link
Contributor Author

heka1024 commented Mar 8, 2024

lpos requires version >= 6.0.6. Close PR until found a nice way to support lower versions.

@jeremy
Copy link
Member

jeremy commented Mar 12, 2024

Docs are sufficient here since it's a new capability, e.g. list.include? requires Redis 6+ with LPOS support. People can keep using list.elements.include? otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants