Short navigation jobs count #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch defines the `number_to_human` format and units option to make the navigation section titles more compact and readable. As an example, instead of "Finished Jobs (4.4 Thousand)" it will now display "Finished Jobs (4.4K)". https://api.rubyonrails.org/classes/ActiveSupport/NumberHelper.html#method-i-number_to_human
|
Please let me know if you'd like me to add some tests around this patch. I took a quick look, but wasn't sure where it would be appropriate to add them or if it's worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch defines the
number_to_humanformat and units option to make the navigation section titles more compact and readable.As an example, instead of "Finished Jobs (4.4 Thousand)" it will now display "Finished Jobs (4.4K)".
https://api.rubyonrails.org/classes/ActiveSupport/NumberHelper.html#method-i-number_to_human
Before:
After:
