Add config.mission_control.jobs.irb_help that defaults to true #84
Conversation
lib/mission_control/jobs/engine.rb
Outdated
| @@ -11,7 +11,7 @@ class Engine < ::Rails::Engine | |||
| isolate_namespace MissionControl::Jobs | |||
|
|
|||
| config.mission_control = ActiveSupport::OrderedOptions.new unless config.try(:mission_control) | |||
| config.mission_control.jobs = ActiveSupport::OrderedOptions.new | |||
| config.mission_control.jobs = ActiveSupport::OrderedOptions.new(irb_help: true) | |||
There was a problem hiding this comment.
Why do you need to add this single option here? 🤔
There was a problem hiding this comment.
It's to provide a default, otherwise it's nil, I don't get why the default: true doesn't work
There was a problem hiding this comment.
That's very odd, you should dig into that instead of just patching it like this, without understanding what's happening.
lib/mission_control/jobs.rb
Outdated
| @@ -16,5 +16,6 @@ module Jobs | |||
| mattr_accessor :delay_between_bulk_operation_batches, default: 0 | |||
| mattr_accessor :logger, default: ActiveSupport::Logger.new(nil) | |||
| mattr_accessor :internal_query_count_limit, default: 500_000 # Hard limit to keep unlimited count queries fast enough | |||
| mattr_accessor :irb_help, default: true | |||
There was a problem hiding this comment.
Perhaps we could call this show_console_help or something like this, to be a bit more explicit? We use console in Rails initialization, rather than irb.
dorianmariecom
force-pushed
the
dorian/irb-help
branch
2 times, most recently
from
1ec92a2
to
7e4dd1e
Compare
lib/mission_control/jobs/engine.rb
Outdated
| @@ -11,17 +11,15 @@ class Engine < ::Rails::Engine | |||
| isolate_namespace MissionControl::Jobs | |||
|
|
|||
| config.mission_control = ActiveSupport::OrderedOptions.new unless config.try(:mission_control) | |||
| config.mission_control.jobs = ActiveSupport::OrderedOptions.new | |||
| config.mission_control.jobs = MissionControl::Jobs | |||
There was a problem hiding this comment.
We don't want the config to point to this module, we want mission_control.jobs to behave as any other app config. This should be kept as it was, as ActiveSupport::OrderedOptions.new.
There was a problem hiding this comment.
Makes sense, done
lib/mission_control/jobs/engine.rb
Outdated
| @@ -79,7 +77,9 @@ class Engine < ::Rails::Engine | |||
| MissionControl::Jobs::Current.server = application.servers.first | |||
| end | |||
|
|
|||
| puts "\n\nType 'jobs_help' to see how to connect to the available job servers to manage jobs\n\n" | |||
| if config.mission_control.jobs.show_console_help | |||
There was a problem hiding this comment.
I think you should use MissionControl::Jobs.show_console_help here, as the initialization process has completed if you're opening a console.
There was a problem hiding this comment.
Thanks, that works, done and rebased
To display or hide the irb help message
dorianmariecom
force-pushed
the
dorian/irb-help
branch
from
3dd61b5
to
c458999
Compare
To display or hide the irb help message
Fixes #76