Fix collisions with existing user and group ids #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add groups or users if ther gid or uid already exists in the base image. We also make useradd and the USER instruction depend on numeric ids since we can't guarantee that a group or user with name 'app' exists. The USER instruction now also includes the group id to ensure that any created files have the expected user and group ownership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add groups or users if ther gid or uid already exists in the base image. We also make useradd and the USER instruction depend on numeric ids since we can't guarantee that a group or user with name
appexists.The USER instruction now also includes the group id to ensure that any created files have the expected user and group ownership.