Adjust absolute paths on Windows for Docker #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this PR successfully. |
|
Built and tested locally on a Windows 10 host and rails-new was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows Docker CLI has very specific requirements for absolute paths on Windows. The tool accepts absolute path formats such as
/c/path/to/dest.The Rust
canonicalizefunction creates a UNC path which the Docker CLI command does not accept.This PR addresses the issue #28 by adding a new function with a custom block of Windows only code (using
cfg!macro) to reformat the path to a Docker CLI compatible path string. On other OSes, the string is returned as it was before, unchanged.