Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default Ruby version to 3.3.5 #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Bump default Ruby version to 3.3.5 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG RUBY_VERSION=3.3.4
ARG RUBY_VERSION=3.3.5
FROM ruby:${RUBY_VERSION}
ARG RAILS_VERSION
# Install Rails based on the version specified but if not specified, install the latest version.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.unix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG RUBY_VERSION=3.3.4
ARG RUBY_VERSION=3.3.5
FROM ruby:${RUBY_VERSION}
ARG USER_ID=1000
ARG GROUP_ID=1000
Expand Down
4 changes: 2 additions & 2 deletions src/rails_new.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pub struct Cli {
#[clap(trailing_var_arg = true, required = true)]
/// arguments passed to `rails new`
pub args: Vec<String>,
#[clap(long, short = 'u', default_value = "3.3.4")]
#[clap(long, short = 'u', default_value = "3.3.5")]
pub ruby_version: String,
#[clap(long, short = 'r', default_value = "7.2.0")]
pub rails_version: String,
Expand Down Expand Up @@ -54,7 +54,7 @@ mod tests {
let ruby_version = m.get_one::<String>("ruby_version").unwrap();
let rails_version = m.get_one::<String>("rails_version").unwrap();

assert_eq!(ruby_version, "3.3.4");
assert_eq!(ruby_version, "3.3.5");
assert_eq!(rails_version, "7.2.0");

Ok(())
Expand Down
Loading