Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Current Migration Version #370

Closed

Conversation

robertomiranda
Copy link

Hola 👋

I've noticed that when installing Solid Queue in Rails projects (version 7.1 and above), the generator continues to use the older version for the queue schema, 7.1. I'm curious if this is intentional and whether aligning it with the current project version might be more appropriate. As of now, Rails versions 7.1, 7.2, and 8.0 don't seem to have any compatibility issues, so this hasn't caused problems.

https://github.com/rails/rails/blob/4f68f3e1e6c2eaad8256100dad51d308e7e67046/activerecord/lib/active_record/migration/compatibility.rb#L32-L38

However, for future Rails releases, it might be beneficial for the generator to track and use the version in use.

Gracias 🙇

@dhh
Copy link
Member

dhh commented Oct 5, 2024

Older schema versions will always be supported. The versioning is there in case the syntax changes. So all is good as-is.

@dhh dhh closed this Oct 5, 2024
@robertomiranda robertomiranda deleted the current-schema-version branch October 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants