Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify file name where custom application root is required when using Spring with a Rails engine #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boddhisattva
Copy link

Background:

When attempting to using Spring with a Rails engine, I wasn't quite sure in which file do I need to include Spring.application_root = './test/dummy' in order to use it. I found the answer after some googling around via this link. IMHO it could be useful to have the same info in the README so that people exactly know how to use Spring in the context of a special setup like a Rails engine.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @jonleighton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants