Avoid using Sprockets::Utils.module_include
in SasscProcessor
#798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #759 a mutex lock was added to
Sprockets::Utils.module_include
to make it thread safe. Forsass
it was the only option, becauseSass::Engine
does not allow user to configure where functions are loaded from.However, for
SasscProcessor
we don't have to suffer from this lock, becauseSassC::Engine
's API allows user to directly specify a user definedModule
for functions:https://github.com/sass/sassc-ruby/blob/4fce2b635ca5d616a8b1381c64846410bc785ea4/lib/sassc/engine.rb#L19
So instead of including
@functions
intoSassC::Script::Functions
, we can do the other way around, which is to includeSassC::Script::Functions
into@functions
and then pass@functions
into the engine. This way we have thread safety without the mutex lock.cc @chadlwilson @rafaelfranca