Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mailer generation with namespaces #308

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Jan 7, 2024

Fixes #272

I'm a little confused why this gem implements mailer generation if it's just a copy-paste from rails, but if we're going to do it, then we need the layout files as well.

cc @dixpac from #84

@dixpac
Copy link
Contributor

dixpac commented Jan 7, 2024

👍

@flavorjones @dhh I wish we could just make one of the next engine versions railties >= 7, initially I had to jump through all kind of hoops with the generator just to make it work with both 6 and 7, because there was a "large" change in rails 7 scaffolds.

@flavorjones
Copy link
Member Author

@dixpac Thanks for the 👀 and the note about Rails 7 generators (which I wasn't aware of).

🤔 I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

@flavorjones flavorjones merged commit 771d3ad into main Jan 7, 2024
22 checks passed
@flavorjones flavorjones deleted the 272-flavorjones-fix-generator-mailer-nested branch January 7, 2024 19:21
@dixpac
Copy link
Contributor

dixpac commented Jan 7, 2024

🤔 I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

Good question, I guess we should :)

@dixpac Thanks for the 👀 and the note about Rails 7 generators (which I wasn't aware of).

I basically had to copy rails 7 default generator and call it tailwindcss generator, so anyone that is using rails 6 can have rails 7 like behavior with divs and partials instead of old html tables that were used in rails 6.

@flavorjones
Copy link
Member Author

🤔 I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

Good question, I guess we should :)

I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind breaks rails mailer generator for namespaced files
2 participants