-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimizable console #330
base: main
Are you sure you want to change the base?
Conversation
Could you post why this feature it needed and a GIF on how it works? |
var isMinimized = container.style.display === 'none' | ||
container.style.display = isMinimized ? 'block' : 'none'; | ||
minimizedConsole.style.display = isMinimized ? 'none' : 'block'; | ||
_this.setCookie('console_minimized', isMinimized ? 'false' : 'true', 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use this.commandStorage
(a Local Storage backed store) instead of a cookie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am honest, I am not sure without looking into how it works in full. It clearly persists as the console remembers stuff after a page refresh, I just don't know if I can wack anything into it.
Also, If this pr gets accepted, I actually would like to do more with the front end regarding remembering console height. position, text size and perhaps even some simple styling options such as opacity to see behind the console. If command storage can support that then I don't see why not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, it's a wrapper for the native LocalStorage browser API. All modern browsers supports it.
To be even more honest, our frontend has been neglected for years, a clean slate rewrite can be the best thing I do. There is no need on the Action View dependency as well.
The web console should offer the option to be minimized, as its current placement obstructs the user interface. The need to repeatedly close the console upon each page reload is frustrating. Similarly, commenting it out proves to be a hassle, especially when it's required later, necessitating a the user to work to get the page to state in which they want to use the console.