Add an option to ignore unnecessary directories such as node_modules/
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mktakuya
changed the title
node_modules/ and tmp/node_modules/
mktakuya
force-pushed
the
feature/ignore-patterns
branch
from
0963181 to
95d7ac7
Compare
dymk
reviewed
Jan 3, 2025
lib/rails_live_reload/config.rb
Outdated
Comment on lines
41
to
44
| @ignore_patterns = [ | ||
| %r{node_modules/} | ||
| ] | ||
| @default_ignore_patterns_changed = false |
There was a problem hiding this comment.
Personally, I would keep this simple and backwards compatible with RLR as it exists today, and not by default ignore node_modules which may break some people's existing expectations for their project (especially not without updating documentation to indicate that node_modules is ignored). Rather, I think modifying the generator as you've done is plenty.
It also lets you simplify things by having @ignore_patterns = [] in the initializer without needing the @default_ignore_patterns_changed state.
There was a problem hiding this comment.
mktakuya
force-pushed
the
feature/ignore-patterns
branch
2 times, most recently
from
32a8856 to
3c55416
Compare
The `Listen.to` method accepts an `ignore` option, allowing the listener to ignore paths matching specified patterns. In this commit, the `ignore` option passed to the Listen.to method is made configurable through a configuration file.
mktakuya
force-pushed
the
feature/ignore-patterns
branch
from
3c55416 to
a8955fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces an
ignoreoption to the configuration settings.Motivation / Background
In my hobby application, I encountered an error caused by the
rails_live_reloadgem monitoring JavaScript files under thenode_modules/directory.After investigating the issue, I found that properly configuring the
ignoreoption in theListen.tomethod, which is used internally by this gem, resolves the problem.To help other developers address similar issues independently, I added the
ignoreoption to the gem's configuration settings.Related issue: #38