[scraper-documentation] beautify readme #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manasakalaga These changes are great, but not in respect to the correct Issue. I think I wasn't able to explain the issue well. I referred to in Scrapper Service in Deployment here in this README. |
|
@sagar-sehgal given that the changes are required in that file too, I'd make the changes to README in the root folder and push it as-well. Would that be okay? |
|
It would be great if you make a separate PR for that. It would be easy to separate and understand. |
|
Here it is. #61 |
thesagarsehgal
approved these changes
Mar 23, 2020
rajatkb
added
beginner
|
@manasakalaga I will merge this one, can you attend to the other files also. See where it can use some improvements. Like all the sections of the project. Maybe setup headers to be filled with content later etc. |
rajatkb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with
READMEin scrapper service as mentioned in #40