Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release pr check #33

Merged
merged 16 commits into from
Nov 29, 2023
Merged

release pr check #33

merged 16 commits into from
Nov 29, 2023

Conversation

rajbos
Copy link
Owner

@rajbos rajbos commented Nov 29, 2023

This pull request includes a wide range of changes to improve the functionality, usability, and maintainability of the codebase. The most important changes include adding new variables and functions to the getAlerts function, updating the interface IResponse for improved error handling, and making various updates to configuration files and widget scripts.

Main interface changes:

  • dependencyReviewTask/index.ts: Added new variables, created a new WebApi instance, obtained system variables, and called the checkAlertsForType function based on the values of scanForDependencyAlerts and scanForCodeScanningAlerts. Updated the interface IResponse to include an additional parameter alertType. [1] [2]
  • widgets/library.js: Made various changes to improve code readability, maintainability, and debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Configuration improvements:

  • vss-extension.json: Made several changes to the vss-extension.json file, including adding a new widget configuration and task, updating URIs for existing widgets, and modifying properties to align with expected formats. [1] [2] [3] [4] [5] [6]
  • dependencyReviewTask/task.json: Updated the name, description, and help markdown to reflect a change in focus.
  • vss-extension-dev.json: Made updates to the vss-extension-dev.json file, including reformatting properties, updating the version number, modifying the supportedScopes property, and adding additional paths for extension files. [1] [2] [3] [4] [5] [6]

Testing improvements:

  • widgets/widgets/widget_1x1/widget_1x1.js: Made changes to load alerts for all repositories in the project if data.repo is not provided, update the function signature and call, and add logging statements. [1] [2] [3]

Documentation updates:

  • overview.md: Added information about a new pipeline task called "Advanced-Security-Review".

Build and script updates:

  • make.ps1: Updated the build script to accept the "publish" command, use the correct variable to create the extension, and add support for building both the dev and prod versions. [1] [2] [3]

Other changes:

  • widgets/widgets/widget_2x1/widget_2x1.html: Removed the unused import of "VSS/Authentication/Services".
  • widgets/widgets/widget_1x1/configuration_1x1.html: Made changes to handle undefined properties, use optional chaining, and improve code reuse. [1] [2] [3]
  • widgets/widgets/widget_1x1/widget_1x1.html: Made changes to add logging statements and update the function signature and calls. [1] [2]
  • z-status.txt: Added text to indicate changes made in branch.
  • .github/workflows/handle-versioning-accross-branches.yml: Added a workflow file to handle versioning across branches.- PR-task: support multiple AlertTypes to check
  • Add config and load option for "all repos in project" [Experimental]

@rajbos rajbos merged commit 9dd73ba into main Nov 29, 2023
1 of 2 checks passed
@rajbos rajbos deleted the release-pr-check branch November 29, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant