(#168) Fixed editor placeholder on change of insets (#169)

rajdeep · Apr 14, 2023 · ed92d74 · ed92d74
1 parent 156f753
commit ed92d74
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/Proton/Sources/Swift/Core/RichTextView.swift b/Proton/Sources/Swift/Core/RichTextView.swift
@@ -78,6 +78,18 @@ class RichTextView: AutogrowingTextView {
         }
     }
 
+    override var contentInset: UIEdgeInsets {
+        didSet {
+            updatePlaceholderVisibility()
+        }
+    }
+
+    override var textContainerInset: UIEdgeInsets {
+        didSet {
+            updatePlaceholderVisibility()
+        }
+    }
+
     private func adjustedTextBlockRangeOnSelectionChange(oldRange: NSRange?, newRange: NSRange?) -> NSRange? {
         guard let old = oldRange,
               let new = newRange,

diff --git a/Proton/Tests/Editor/EditorSnapshotTests.swift b/Proton/Tests/Editor/EditorSnapshotTests.swift
@@ -41,6 +41,22 @@ class EditorSnapshotTests: SnapshotTestCase {
         assertSnapshot(matching: viewController.view, as: .image, record: recordMode)
     }
 
+    func testUpdatesPlaceholderWithInsets() {
+        let viewController = EditorTestViewController()
+        let editor = viewController.editor
+        editor.contentInset = .zero
+        editor.textContainerInset = .zero
+        let font = UIFont(name: "Verdana", size: 17) ?? UIFont()
+        let placeholderString = NSMutableAttributedString(string: "Placeholder text", attributes: [
+            NSAttributedString.Key.font: font,
+            NSAttributedString.Key.foregroundColor: UIColor.lightGray
+        ])
+
+        editor.placeholderText = placeholderString
+        viewController.render(size: CGSize(width: 300, height: 60))
+        assertSnapshot(matching: viewController.view, as: .image, record: recordMode)
+    }
+
     func testRendersMatchContentAttachment() {
         let viewController = EditorTestViewController()
         let editor = viewController.editor

diff --git a/...Editor/__Snapshots__/EditorSnapshotTests/testUpdatesPlaceholderWithInsets.1.png b/...Editor/__Snapshots__/EditorSnapshotTests/testUpdatesPlaceholderWithInsets.1.png