Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Remove duplicate evaluations
  • Loading branch information
ralexstokes authored Apr 16, 2024
1 parent 8c6c803 commit cffaeb8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions spec-tests/runners/kzg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ fn run_blob_to_kzg_commitment_test(
Ok(())
} else {
// `output` is `null`, implying the spec code should always fail
let result = blob_to_kzg_commitment(&blob, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down Expand Up @@ -97,7 +96,6 @@ fn run_compute_kzg_proof_test(test: &TestCase, kzg_settings: &KzgSettings) -> Re
assert_eq!(proof_and_evaluation, expected_proof_and_evaluation);
Ok(())
} else {
let result = compute_kzg_proof(&blob, &z, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down Expand Up @@ -157,7 +155,6 @@ fn run_verify_kzg_proof_test(test: &TestCase, kzg_settings: &KzgSettings) -> Res
Ok(())
}
} else {
let result = verify_kzg_proof(&commitment, &z, &y, &proof, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down Expand Up @@ -198,7 +195,6 @@ fn run_compute_blob_kzg_proof_test(
assert_eq!(proof, expected_proof);
Ok(())
} else {
let result = compute_blob_kzg_proof(&blob, &commitment, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down Expand Up @@ -252,7 +248,6 @@ fn run_verify_blob_kzg_proof_test(
Ok(())
}
} else {
let result = verify_blob_kzg_proof(&blob, &commitment, &proof, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down Expand Up @@ -304,7 +299,6 @@ fn run_verify_blob_kzg_proof_batch_test(
Ok(())
}
} else {
let result = verify_blob_kzg_proof_batch(&blobs, &commitments, &proofs, kzg_settings);
assert!(result.is_err());
Ok(())
}
Expand Down

0 comments on commit cffaeb8

Please sign in to comment.