Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auxiliary deposit functions #378

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

jacobkaufmann
Copy link
Contributor

resolves #375

@jacobkaufmann
Copy link
Contributor Author

can remove generated electra spec if desired

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! think we can clean a few things up, left comments

ethereum-consensus/src/phase0/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/phase0/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/phase0/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/altair/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/altair/block_processing.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! two questions

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@ralexstokes ralexstokes merged commit 451fc62 into ralexstokes:main Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit refactoring in phase0
2 participants