-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: electra block processing #391
feat: electra block processing #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just did a quick skim but looks great so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! going to make another review pass on the block_processing
mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! left some comments on code, haven't done a fine-toothed pass on spec correctness but may defer to another time
@@ -189,6 +194,8 @@ pub enum InvalidVoluntaryExit { | |||
ValidatorIsNotActiveForLongEnough { current_epoch: Epoch, minimum_time_active: Epoch }, | |||
#[error("voluntary exit has invalid signature: {0:?}")] | |||
InvalidSignature(BlsSignature), | |||
#[error("validator has non-zero pending balance to withdraw in queue")] | |||
NonZeroPendingBalanceToWithdraw, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making a comment on the spec, but this is a bit weird lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work!
#373
add block processing functions for the
electra
spec.