Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: electra block processing #391

Merged

Conversation

jacobkaufmann
Copy link
Contributor

@jacobkaufmann jacobkaufmann commented Apr 23, 2024

#373

add block processing functions for the electra spec.

@jacobkaufmann jacobkaufmann marked this pull request as draft April 24, 2024 02:14
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did a quick skim but looks great so far!

@jacobkaufmann jacobkaufmann marked this pull request as ready for review April 24, 2024 17:33
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! going to make another review pass on the block_processing mod

ethereum-consensus/src/electra/helpers.rs Show resolved Hide resolved
ethereum-consensus/src/error.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/error.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! left some comments on code, haven't done a fine-toothed pass on spec correctness but may defer to another time

ethereum-consensus/src/electra/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/block_processing.rs Outdated Show resolved Hide resolved
ethereum-consensus/src/electra/block_processing.rs Outdated Show resolved Hide resolved
@@ -189,6 +194,8 @@ pub enum InvalidVoluntaryExit {
ValidatorIsNotActiveForLongEnough { current_epoch: Epoch, minimum_time_active: Epoch },
#[error("voluntary exit has invalid signature: {0:?}")]
InvalidSignature(BlsSignature),
#[error("validator has non-zero pending balance to withdraw in queue")]
NonZeroPendingBalanceToWithdraw,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making a comment on the spec, but this is a bit weird lol

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@ralexstokes ralexstokes merged commit 43ca5e0 into ralexstokes:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants