Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods that reimplement underlying functionality of List and Vector #148

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ralexstokes
Copy link
Owner

Originally, the mutable APIs into the underlying type that List and Vector wrap were specialized to the local wrapping types so that mutations could be tracked along the way to support caching a la #17.

I'd like to release a v1 of this library and won't have caching support so go ahead and drop the specialized implementations here, in lieu of just exposing the full functionality of the wrapped types.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.02%. Comparing base (fddda62) to head (364270b).

Files Patch % Lines
ssz-rs/src/list.rs 50.00% 1 Missing ⚠️
ssz-rs/src/vector.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   64.32%   64.02%   -0.31%     
==========================================
  Files          20       20              
  Lines        1183     1173      -10     
==========================================
- Hits          761      751      -10     
  Misses        422      422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ralexstokes ralexstokes merged commit 9a238ce into main Apr 2, 2024
3 of 5 checks passed
@ralexstokes ralexstokes deleted the clean-up-list-vector-methods branch April 2, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant