Good error message on too big resolution.

ralfbiedert · Apr 4, 2024 · 4bf566a · 4bf566a
1 parent 6e1fc69
commit 4bf566a
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/openh264/src/encoder.rs b/openh264/src/encoder.rs
@@ -333,6 +333,16 @@ impl Encoder {
     }
 
     fn reinit(&mut self, width: i32, height: i32) -> Result<(), Error> {
+        // https://github.com/cisco/openh264/blob/master/README.md
+        // > Encoder errors when resolution exceeds 3840x2160
+        //
+        // Some more detail here:
+        // https://github.com/cisco/openh264/issues/3553
+        // > Currently the encoder/decoder could only support up to level 5.2,
+        if width > 3840 || height > 2160 {
+            return Err(Error::msg("Encoder max resolution 3840x2160"));
+        }
+
         let mut params = SEncParamExt::default();
 
         unsafe { self.raw_api.get_default_params(&mut params).ok()? };