Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add encoding for read md file #482

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add encoding for read md file #482

wants to merge 4 commits into from

Conversation

Lchiffon
Copy link

read_file function should have a rgument for encoding="UTF-8"

Can't use Chinese character in Windows without that~

GegznaV
GegznaV approved these changes Oct 5, 2016
View reviewed changes
Copy link

@GegznaV GegznaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lchiffon your suggestion to add encoding="UTF-8" in read_file is really helpful. It enabled me to have possibility to use my native language in slidify slides. I hope your bug fixes and pull request will be accepted shortly.

This was referenced Oct 5, 2016
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GegznaV GegznaV GegznaV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lchiffon @GegznaV