Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo of explicit restriction in RestrictionReason #332

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix: Typo of explicit restriction in RestrictionReason #332

merged 2 commits into from
Jun 21, 2022

Conversation

hrkfdn
Copy link
Contributor

@hrkfdn hrkfdn commented Jun 21, 2022

Description

Looks like there is a typo in the enum values. Not sure if this would considered a breaking change since the enum options are changing.

Motivation and Context

hrkfdn/ncspot#844

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

See link above. I didn't explicitly test it, but it's surely a typo :)

Copy link
Collaborator

@marioortizmanero marioortizmanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Merging when CI is done, thanks.

@marioortizmanero marioortizmanero merged commit cc4c45a into ramsayleung:master Jun 21, 2022
@hrkfdn
Copy link
Contributor Author

hrkfdn commented Jun 24, 2022

Thanks @marioortizmanero, just out of curiosity: is a release planned anytime soon?

@marioortizmanero
Copy link
Collaborator

marioortizmanero commented Jun 24, 2022

I was hoping to merge #331, #329, #327 and #305 as a new 0.12 release, if that's fine with you. They should be almost done already and only need feedback before merging.

@marioortizmanero
Copy link
Collaborator

Another option is to merge all of the PRs except for #305, which is the truly breaking & bigger change, and release a 0.11.6 release in the meanwhile. But it depends on how fast we can merge the other ones and etc.

@hrkfdn
Copy link
Contributor Author

hrkfdn commented Jun 24, 2022

The second approach sounds nice, but please don't feel rushed by this comment or my previous question :) Thanks!

@hrkfdn
Copy link
Contributor Author

hrkfdn commented Dec 13, 2022

Sooo @marioortizmanero, any plans for a bugfix release? 😅

@ramsayleung ramsayleung mentioned this pull request Dec 14, 2022
4 tasks
@ramsayleung
Copy link
Owner

I released a new version: #373

@hrkfdn
Copy link
Contributor Author

hrkfdn commented Dec 14, 2022

Thanks @ramsayleung ❤️

hrkfdn added a commit to hrkfdn/ncspot that referenced this pull request Dec 14, 2022
Passing IDs to rspotify still feels a little wonky with their `Id` changes
making use of `Cow`. Maybe it can be simplified on our end, but it's a start.

Fixes #844

See also:

ramsayleung/rspotify#332
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 29, 2022
Maintenance
 - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332)
 - Fix: Print "Connecting to Spotify" before setting up Cursive backend by
   @pghvlaans (#969)
 - Link to Flatpak image by @thorpelawrence (#997)
 - Make entry point synchronous and switch to global runtime instead by
   @ThomasFrans (#996)
 - Document queue module by @ThomasFrans (#1009)

Features
 - Add "save/unsave album" to context menu (#964)
 - Automatically save backtraces to cache folder by @ThomasFrans (#988)
 - Create IPC socket on UNIX platforms for remote control and external track
   display (#1018)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 18, 2023
Maintenance
 - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332)
 - Fix: Print "Connecting to Spotify" before setting up Cursive backend by
   @pghvlaans (#969)
 - Link to Flatpak image by @thorpelawrence (#997)
 - Make entry point synchronous and switch to global runtime instead by
   @ThomasFrans (#996)
 - Document queue module by @ThomasFrans (#1009)

Features
 - Add "save/unsave album" to context menu (#964)
 - Automatically save backtraces to cache folder by @ThomasFrans (#988)
 - Create IPC socket on UNIX platforms for remote control and external track
   display (#1018)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 23, 2023
Maintenance
 - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332)
 - Fix: Print "Connecting to Spotify" before setting up Cursive backend by
   @pghvlaans (#969)
 - Link to Flatpak image by @thorpelawrence (#997)
 - Make entry point synchronous and switch to global runtime instead by
   @ThomasFrans (#996)
 - Document queue module by @ThomasFrans (#1009)

Features
 - Add "save/unsave album" to context menu (#964)
 - Automatically save backtraces to cache folder by @ThomasFrans (#988)
 - Create IPC socket on UNIX platforms for remote control and external track
   display (#1018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants