Cleanup with more clippy lints #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioortizmanero
force-pushed
the
clippy-lints
branch
from
c5ad908
to
dadcae9
Compare
4 tasks
marioortizmanero
force-pushed
the
clippy-lints
branch
from
17842a1
to
d27e81c
Compare
marioortizmanero
force-pushed
the
clippy-lints
branch
from
20eb729
to
50c30b3
Compare
ramsayleung
reviewed
Jul 31, 2022
| @@ -217,7 +217,7 @@ pub mod space_separated_scopes { | |||
| D: de::Deserializer<'de>, | |||
| { | |||
| let scopes: &str = Deserialize::deserialize(d)?; | |||
| Ok(scopes.split_whitespace().map(|x| x.to_owned()).collect()) | |||
| Ok(scopes.split_whitespace().map(ToOwned::to_owned).collect()) | |||
ramsayleung
reviewed
Jul 31, 2022
| @@ -210,6 +210,7 @@ macro_rules! define_idtypes { | |||
| /// Only returns `true` in case the given string is valid | |||
| /// according to that specific ID (e.g., some may require | |||
| /// alphanumeric characters only). | |||
| #[must_use] | |||
There was a problem hiding this comment.
Just out of curiosity, these functions are all must_use ?
There was a problem hiding this comment.
What do you mean? Yes, I marked all of them with must_use because clippy told me to, and it makes sense.
ramsayleung
reviewed
Jul 31, 2022
| MinValence(x) => x.to_string(), | ||
| MaxValence(x) => x.to_string(), | ||
| TargetValence(x) => x.to_string(), | ||
| MinAcousticness(x) |
ramsayleung
reviewed
Jul 31, 2022
| @@ -5,7 +5,7 @@ use std::collections::HashMap; | |||
| use serde::Serialize; | |||
| use std::marker::PhantomData; | |||
|
|
|||
| pub(crate) fn build_map<'key, 'value, const N: usize>( | |||
| pub fn build_map<'key, 'value, const N: usize>( | |||
There was a problem hiding this comment.
Will this change the visibility from crate public to globally public?
There was a problem hiding this comment.
Because the entire module is already public to the crate only. No need to do that again.
ramsayleung
reviewed
Jul 31, 2022
ramsayleung
approved these changes
Jul 31, 2022
|
This PR is ready to merge, but the |
|
That's weird... Maybe try disabling the adblocker or something like that? I'll merge myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up a lot of code thanks to the clippy lints described in #204.
Cargo.toml(categoriesfield)#[must_use]Selfwhere possibleOffsetconstructorsMotivation and Context
Some code is overly complex or not well annotated.
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
CI still passes
Is this change properly documented?
Yes