Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #70: return full text article #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

supercoder-dev
Copy link

No description provided.

Copy link

@holygeek00 holygeek00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to solving issue #70 by returning the full text of the article. The changes are heading in the right direction. Here are a few suggestions to improve the implementation:

Documentation Update:
The docstring for the get_full_article method needs to be updated to reflect the new behavior accurately. The current docstring mentions returning an Article object, but now the method returns the full text of the article.

Error Handling:
When the article text is less than 200 characters, the function attempts to use BeautifulSoup to parse the HTML. It's a good approach, but we should add a check to ensure that article.html is not None before parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants