-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Analyst Data from the Analysis section of Yahoo Finance #1668
base: dev
Are you sure you want to change the base?
Conversation
…and related tests). Signed-off-by: Scott W. Strong <[email protected]>
@ranaroussi @ValueRaider Please let me know if there is anything you have questions about and/or would like modified. I needed analyst data for a project I'm working on, so I'll use the forked version until this gets merged in main. Best, Scott |
Try to avoid tagging specific people for review, let the wider community review. |
I've pushed some changes to improve formatting of table contents. Review and discuss, reverting is an option. |
713accb
to
0e4f358
Compare
These changes look like solid improvements to make things more consistent with how other data is formatted throughout the library. Looks good to me! |
Can you fix the conflicts? |
FYI, I cannot view or fix the conflicts here. If there is a way for someone else to do this (or help me figure it out), that would be great. Thanks! |
Basically, try merging latest No idea why Github struggling. |
How about merging this? What's the status? Would be very useful for me :) |
Can someone please address the conflicts here? For some reason I cannot do it myself because I don't have the right permissions on this repo. I've been waiting to update a docker instance I have in production with a recent version of yfinance, and it's now failing because I don't have an updated version. |
Given the passage of time making conflicts harder to resolve, easiest option might be manually replicate in a new branch. |
Support for Analyst Data from the Analysis section of Yahoo Finance (and related tests).