Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Analyst Data from the Analysis section of Yahoo Finance #1668

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sstrong617
Copy link

Support for Analyst Data from the Analysis section of Yahoo Finance (and related tests).

@sstrong617
Copy link
Author

@ranaroussi @ValueRaider Please let me know if there is anything you have questions about and/or would like modified. I needed analyst data for a project I'm working on, so I'll use the forked version until this gets merged in main. Best, Scott

@ValueRaider
Copy link
Collaborator

Try to avoid tagging specific people for review, let the wider community review.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Sep 17, 2023

I've pushed some changes to improve formatting of table contents. Review and discuss, reverting is an option.

@sstrong617
Copy link
Author

I've pushed some changes to improve formatting of table contents. Review and discuss, reverting is an option.

These changes look like solid improvements to make things more consistent with how other data is formatted throughout the library.

Looks good to me!

@ValueRaider
Copy link
Collaborator

Can you fix the conflicts?

@sstrong617
Copy link
Author

FYI, I cannot view or fix the conflicts here. If there is a way for someone else to do this (or help me figure it out), that would be great.

Thanks!

@ValueRaider
Copy link
Collaborator

ValueRaider commented Jan 19, 2024

Basically, try merging latest dev branch into your feature branch, or rebase from parent commit to latest dev. Sync your fork first.

No idea why Github struggling.

@VolkerFelix
Copy link

How about merging this? What's the status? Would be very useful for me :)

@sstrong617
Copy link
Author

Can someone please address the conflicts here? For some reason I cannot do it myself because I don't have the right permissions on this repo. I've been waiting to update a docker instance I have in production with a recent version of yfinance, and it's now failing because I don't have an updated version.

@ValueRaider
Copy link
Collaborator

Given the passage of time making conflicts harder to resolve, easiest option might be manually replicate in a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants