[WIP] 🌱 feat: ClusterClass - add RKE2ControlPlaneTemplate #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
feat-add-support-for-clusterclass
branch
3 times, most recently
from
6ae2aea
to
9d088be
Compare
salasberryfin
force-pushed
the
feat-add-support-for-clusterclass
branch
2 times, most recently
from
9d14d35
to
252f22f
Compare
salasberryfin
force-pushed
the
feat-add-support-for-clusterclass
branch
2 times, most recently
from
f424608
to
adfd89e
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
feat-add-support-for-clusterclass
branch
from
adfd89e
to
c49b579
Compare
salasberryfin
changed the title
salasberryfin
changed the title
salasberryfin
changed the title
|
We'll be editing these changes to be added to the new API version |
4 tasks
|
We can wait for a new CAPI release that includes the configurable bootstrap timeout in CAPD. |
4 tasks
|
This PR is superseded by #261, which moves this feature to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
RKE2ControlPlaneTemplate, which will be used by ClusterClass. It also includes a quick start example to create a sampleClusterClassand a workloadClusterbased on it.Which issue(s) this PR fixes:
Fixes #75
Special notes for your reviewer:
The example ClusterClass makes use of the new configurable bootstrap timeout in CAPD, which is pending merge here. The default timeout is set to 3m, which is sometimes not enough for machine to be provisioned.
Supporting
ClusterClassmeant extra fields had to be added toRKE2ControlPlaneSpec, includingVersion. Since the provider already has a Version field inRKE2AgentConfigSpec, there's a follow up issue, #229, to track work on addressing how these fields are managed, with the goal of deprecatingRKE2AgentConfigSpec.Versionin a future API version.For now, only the existing RKE2AgentConfigSpec.Version is supported and the new
RKE2ControlPlaneSpec.Versionis only a placeholder to support usingClusterClass. A following PR will add the changes to support either of the two fields but not both.Checklist: