Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.2] Fix: e2e tests #268

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Feb 19, 2024

What this PR does / why we need it:
Cherry-pick for #260, #203, #204

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

richardcase and others added 2 commits February 19, 2024 12:56
@Danil-Grigorev Danil-Grigorev added the kind/bug Something isn't working label Feb 19, 2024
furkatgofurov7
furkatgofurov7 previously approved these changes Feb 19, 2024
@Danil-Grigorev
Copy link
Contributor Author

@richardcase @furkatgofurov7 Updated, PTAL again

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

salasberryfin
salasberryfin previously approved these changes Feb 20, 2024
richardcase
richardcase previously approved these changes Feb 20, 2024
@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev just to confirm, have we run e2e tests with these changes?

@Danil-Grigorev
Copy link
Contributor Author

There are some issues with e2e tests on release-0.2 branch, unrelated to any recently merged change. Docker provider fails to update ProviderID field on the machine. Needs to be looked into, just didn’t find time yet

@furkatgofurov7
Copy link
Contributor

maybe #203 needs to be backported?

@richardcase
Copy link
Contributor

maybe #203 needs to be backported?

Yes i think part or all of it my need backporting.....especially this part

  serverConfig:
    disableComponents:
      kubernetesComponents:
      - cloudController

Enabling e2e workflow as a pre-submit job, now that the e2e nightly tests are passing.

Signed-off-by: Danil Grigorev <[email protected]>
@Danil-Grigorev
Copy link
Contributor Author

Tests are passing locally with the change
image

@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev strange, I noticed space issue in the logs in GHA, maybe we can push #204 also on top of current changes and retest?

@richardcase
Copy link
Contributor

@Danil-Grigorev strange, I noticed space issue in the logs in GHA, maybe we can push #204 also on top of current changes and retest?

We could also move to self hosted runners for the e2e. I started to do this but we need to update the VM image.

@Danil-Grigorev
Copy link
Contributor Author

Currently tests are already running longer then before. I think this all fixes e2e completely for now (24GB were freed from the logs), PTAL @furkatgofurov7 @richardcase

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Danil-Grigorev!

/approve

@furkatgofurov7 furkatgofurov7 changed the title [release-0.2] Fix: e2e tests cherry pick [release-0.2] Fix: e2e tests Feb 21, 2024
@Danil-Grigorev Danil-Grigorev merged commit 9b5aa51 into rancher:release-0.2 Feb 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants