-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.2] Fix: e2e tests #268
[release-0.2] Fix: e2e tests #268
Conversation
Signed-off-by: Richard Case <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
@richardcase @furkatgofurov7 Updated, PTAL again |
Signed-off-by: Danil Grigorev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Danil-Grigorev just to confirm, have we run e2e tests with these changes? |
There are some issues with e2e tests on release-0.2 branch, unrelated to any recently merged change. Docker provider fails to update ProviderID field on the machine. Needs to be looked into, just didn’t find time yet |
maybe #203 needs to be backported? |
Yes i think part or all of it my need backporting.....especially this part serverConfig:
disableComponents:
kubernetesComponents:
- cloudController |
Enabling e2e workflow as a pre-submit job, now that the e2e nightly tests are passing. Signed-off-by: Danil Grigorev <[email protected]>
1116ad6
1116ad6
to
6ea16f7
Compare
6ea16f7
to
afa2c96
Compare
Signed-off-by: Richard Case <[email protected]>
@Danil-Grigorev strange, I noticed space issue in the logs in GHA, maybe we can push #204 also on top of current changes and retest? |
Signed-off-by: Richard Case <[email protected]>
We could also move to self hosted runners for the e2e. I started to do this but we need to update the VM image. |
Currently tests are already running longer then before. I think this all fixes e2e completely for now (24GB were freed from the logs), PTAL @furkatgofurov7 @richardcase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Danil-Grigorev!
/approve
What this PR does / why we need it:
Cherry-pick for #260, #203, #204
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: