-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cisProfile option with ignition format #402
Conversation
Review welcome but marking this as a draft until I've tested it e2e locally |
@hardys let's rebase before re-running e2e tests on this one, thanks! |
After testing locally I found another issue:
I think that's because the mode constant here needs updating, will add to this PR and re-test |
I found some more issues which should now be resolved:
|
The latest iteration takes a different approach and mounts the /opt subvolume as described in https://en.opensuse.org/Portal:MicroOS/Ignition#Mounts - I'm still not sure writing the file to /opt is ideal, but with this approach I can avoid changing any of the existing cloud-init related code. |
@alexander-demicev @furkatgofurov7 this is passing CI and now ready for review - please take a look when you get a moment, thanks! |
This causes a `unreasonable mode` error because it's specified as a string not octal like the default mode Signed-off-by: Steven Hardy <[email protected]>
Otherwise the script fails, this aligns with how the cloud-init script works. Signed-off-by: Steven Hardy <[email protected]>
The default path using the script installer writes this to /opt/rke2/share/rke2/rke2-cis-sysctl.conf (on Leap/SLEMicro at least) Signed-off-by: Steven Hardy <[email protected]>
This is not mounted by default, therefore we cannot write the /opt/rke2-cis-script.sh script. So add configuration to mount the subvolume, as described in https://en.opensuse.org/Portal:MicroOS/Ignition#Mounts Signed-off-by: Steven Hardy <[email protected]>
Head branch was pushed to by a user without write access
Currently there are some stray tabs which break the rendered output, replace these with spaces and add some unit test coverage.
kind/bug
What this PR does / why we need it:
Currently the cisProfile option is broken when selecting ignition format for Leap/SLEMicro deployments
Fixes: #401
Checklist: