remove focus-trap directive + improve chaining event handler modifiers

rancher · Jan 17, 2025 · d1cd1f5 · d1cd1f5
1 parent 8a19862
commit d1cd1f5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 32 deletions.
diff --git a/shell/components/form/ColorInput.vue b/shell/components/form/ColorInput.vue
@@ -97,8 +97,7 @@ export default {
     :class="{[mode]:mode, disabled: isDisabled}"
     :data-testid="componentTestid + '-color-input'"
     :tabindex="isDisabled ? -1 : 0"
-    @keyup.enter.stop="handleKeyups($event)"
-    @keyup.space.stop="handleKeyups($event)"
+    @keyup.enter.space.stop="handleKeyups($event)"
   >
     <label class="text-label"><t
       v-if="labelKey"

diff --git a/shell/directives/focus-trap.js b/shell/directives/focus-trap.js
diff --git a/shell/initialize/install-directives.js b/shell/initialize/install-directives.js
@@ -10,7 +10,6 @@ import cleanTooltipDirective from '@shell/directives/clean-tooltip';
 import positiveIntNumberDirective from '@shell/directives/positive-int-number.js';
 import trimWhitespaceDirective from '@shell/directives/trim-whitespace';
 import intNumberDirective from '@shell/directives/int-number';
-import focusTrap from '@shell/directives/focus-trap';
 
 /**
  * Prevent extensions from overriding existing directives
@@ -48,7 +47,6 @@ function addDirectives(vueApp) {
   vueApp.directive('focus', focusDirective);
   vueApp.directive('intNumber', intNumberDirective);
   vueApp.directive('positiveIntNumber', positiveIntNumberDirective);
-  vueApp.directive('trap', focusTrap);
 }
 
 /**