Fetch only specific csp adapter helm apps... instead of all helm apps #10435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts
richard-cox
commented
Feb 13, 2024
- Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes
- fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534
…dall-secret-backup
- Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings
… form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled
- project monitoring (and bug fixes)
- temp step until we get new overview
- only used in monitoring.coreos.com.alertmanagerconfig context
…electOrCreateAuthSecret
- Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response
- general fixes - correct issue were sorting prov clusters on mgmt cluster props (issue in master as well...) - bit the bullet, we now don't fetch all mgmt clusters on dashboard visit. - there could be knock on affects, but we'd need to remove it sometime in 2.11....
…ation-cluster-explorer
- caused by shell/scripts/test-plugins-build.sh importing list/catalog.cattle.io.clusterrepo.vue - the component had been updated to a TS component - check-plugin build outputs TS errors for a component file imports - vs code shows no errors for imported file
…o optimise-branding-apps-fetch
- Remove final todo's - includes fix for service type clusterip/headless overlap - Removed ununused ENDPOINT column (note ENDPOINT formatter used in other columns) - Testing freshly added index fields
…o optimise-branding-apps-fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on
Summary
Fixes #10434
Occurred changes and/or fixed issues
filterparamTechnical notes summary
We fetch all apps when pagination is off and then filter for the required ones. I've kept that same filter in, even though the apps list should only contain the required entries just in case there's socket update shenanigans.
Areas or cases that should be tested
Rough flow
Tab 1 - Refresh - Dashboard in standard blue brand,
Tab 2 - /v3/settings/ui-brand does not exist
Tab 3 - Install csp adatper chart (see #9270)
Tab 1 - Without any intervention branding should change to green.
Tab 2 - /v3/settings/ui-brand should exist and be set to
cspTab 1 - Refresh - branding should remain green
Tab 3 - Uninstall csp adapter chart
Tab 1 - Branding should remain green,
Tab 2 - /v3/settings/ui-brand should exist and be set to
cspTab 2 - /v3/settings/ui-brand DELETE
Tab 1 - Without intervention brandng should be blue,
Tab 1 - Refresh - Dashboard in standard blue brand,
See #9270 for some more detail on how to install the csp adapter chart
Checklist