Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ember routing for hosted clusters that are not EKS AKS nor GKE #12587

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #12541

Occurred changes and/or fixed issues

This PR modifies a change that came in here to support the AKS/EKS/GKE ui extensions, so other hosted providers are still able to load custom ember ui.

Areas or cases that should be tested

Ensure that hosted

Areas which could experience regressions

create,edit, import existing aks/eks/gke clusters -- make sure the vue is still loading for these cluster types

Screenshot/Video

Screen.Recording.2024-11-12.at.12.43.46.PM.mov
Screen.Recording.2024-11-12.at.12.40.14.PM.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md merged commit bf5f646 into rancher:master Nov 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a non-builtin hosted cluster shows the add page instead
2 participants