Remove usages of findAll for core resources in cluster explorer view - 1 #13006

richard-cox · 2025-01-07T15:34:49Z

Blocked on

Requires squash-merge

Summary

PR 1 for #9965

PR chain will remove remaining places where we go out and fetch all of a resource for core resources (but not rbac or cluster related) in the cluster explorer

Occurred changes and/or fixed issues

Converted to use ResourceLabeledSelect (LabelSelect with paging if SSP for type is enabled)
- Questions Resource type
  - To test load add helm repo https://github.com/richard-cox/rodeo, install chart rancher-demo
- Resource detail page's generic Events tab
Replace fetchAll with fetchAll within specific namespace (more risk than full pagination, but cleaner and benefits world where SSP is disabled as well)
- all workload types in the namespace detail page used to show workloads list
  - note that the workloads by state components (top bar and list) get their info from the counts endpoint rather than calculating from all resources
- services and certs (secrets of type tls) in ingress detail page used to show associated resources
  - same but for ingress edit page to show possible associated resources
  - these use a common helper file
Smaller changes
- When the LabelSelect is setup to show pagination controls... hide then if there's a single page
- Minor fixes to shell/components/form/ResourceLabeledSelect.vue
- Added comments that need to be reviewed as part of Application of selectors locally scales badly #10417
- Removed RelatedWorkloadsTable
  - this was added in Migrating the PersistentVolumeClaim pages #2342, but the usage was removed in Replacing the custom related workloads and events tabs on the PVC page #2436. Given it does a findAll on all workload types this seems like a good pr to remove it

Areas or cases that should be tested

Questions Resources type (see above)
Various resource detail page's events tab
namespace detail page's workloads list
ingress creation and edit, specifically selecting certificates and rule service

Areas which could experience regressions

as per above

Checklist

The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
The PR has a Milestone
The PR template has been filled out
The PR has been self reviewed
The PR has a reviewer assigned
The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…nts list

- Functional Changes - SSP now works after vue3 bump - Home Page Clusters list now uses server-side pagination - Side Bar clusters list now uses server-side pagination - Wire in now supported sorting / filtering by id and name used for table columns - Allow pagination to be enabled given a specific context - Call findPage without persisting to store - New Pagination Tools - PaginatedResourceTable - Convenience Component, wraps ResourceTable with pagination specific props - PaginationWrapper - Convenience class to handle requests for resources and updates to them (avoiding store) - Regressions - Side Nav menu ready state was `mgmtCluster.isReady && !pCluster?.hasError`, now ???

…would incorrectly fetch all resources anyway - convert reminaing storage lists

- Functional Changes - SSP now works after vue3 bump - Home Page Clusters list now uses server-side pagination - Side Bar clusters list now uses server-side pagination - Wire in now supported sorting / filtering by id and name used for table columns - Allow pagination to be enabled given a specific context - Call findPage without persisting to store - New Pagination Tools - PaginatedResourceTable - Convenience Component, wraps ResourceTable with pagination specific props - PaginationWrapper - Convenience class to handle requests for resources and updates to them (avoiding store) - Regressions - Side Nav menu ready state was `mgmtCluster.isReady && !pCluster?.hasError`, now ???

Note - prov clusters is broken (only fetches local) due to blocking pr. breals - notPinned list

- remove from resource list, put in resource-fetch (used also by pag res table)

…ation-cluster-explorer

- remove from resource list, put in resource-fetch (used also by pag res table)

…ation-cluster-explorer

- changes namespaces kicked of side nav cluster requests (thought pinnedIds changed) - fix generic lists re-fetching given ns filter changes (they don't have namespaced arg)

…ation-cluster-explorer

…r-explorer

- caused by shell/scripts/test-plugins-build.sh importing list/catalog.cattle.io.clusterrepo.vue - the component had been updated to a TS component - check-plugin build outputs TS errors for a component file imports - vs code shows no errors for imported file

…r-explorer

- Remove final todo's - includes fix for service type clusterip/headless overlap - Removed ununused ENDPOINT column (note ENDPOINT formatter used in other columns) - Testing freshly added index fields

…uper ok

…-findall-1

- use common helper - both require services and secrets (of type cert) in a specific namespace - for ease, just use the existing mechanism

richard-cox · 2025-01-09T13:26:03Z

shell/components/RelatedWorkloadsTable.vue

@@ -1,50 +0,0 @@
-<script>


this was added in #2342, but the usage was removed in #2436. Given it does a findAll on all workload types this seems like a good pr to remove it

richard-cox · 2025-01-09T13:30:04Z

shell/components/form/LabeledSelect.vue

@@ -383,7 +383,7 @@ export default {

      <template #list-footer>
        <div
-          v-if="canPaginate && totalResults"
+          v-if="canPaginate && totalResults && pages > 1"


hide the bottom area of the open drawer if there's no page controls

(visible here, removed if there's a single page)

richard-cox · 2025-01-13T11:23:05Z

Closing in favour of #13025

richard-cox added 30 commits August 19, 2024 16:23

cluster list now uses resource table

25c0c70

New PaginatedResourceTable

eda38cf

WIP

8e120d0

add context to pag setting

203cdfd

tidying up

a0a6883

Add server-side pagination to cluster explorer events and general eve…

8b03d56

…nts list

Servier-side pagination for catalog apps, cluster repo and operation

dcd69ed

Servier-side pagination for Service --> HPA, inmgress, services

34e173b

Merge branch 'pagination-home-page' into pagination-cluster-explorer

bbf4bcd

fixes after merge. apply PagResTable to node list, vue3 fixes

6bfc45d

- Fix issue where list components containing PaginatedResourceTables …

1f61ce5

…would incorrectly fetch all resources anyway - convert reminaing storage lists

policy section

16d1a0f

fix async button in manual refresh mode

006debb

fgh

2454ad3

aaaaa

a94360e

Iteration

f1858b6

Note - prov clusters is broken (only fetches local) due to blocking pr. breals - notPinned list

Merge branch 'pagination-home-page' into pagination-cluster-explorer

475aaef

Fix dupe inStore

96b6b9a

- remove from resource list, put in resource-fetch (used also by pag res table)

Merge remote-tracking branch 'origin/pagination-home-page' into pagin…

c61ad5f

…ation-cluster-explorer

Fix dupe inStore

442d85c

- remove from resource list, put in resource-fetch (used also by pag res table)

Merge remote-tracking branch 'origin/pagination-home-page' into pagin…

fdc99ee

…ation-cluster-explorer

Two fixes

cb18993

- changes namespaces kicked of side nav cluster requests (thought pinnedIds changed) - fix generic lists re-fetching given ns filter changes (they don't have namespaced arg)

Merge remote-tracking branch 'origin/pagination-home-page' into pagin…

0054f40

…ation-cluster-explorer

fixes / updates

66f73da

testing/tidying

a6810c1

WIP - Rest of workload lists

6f56573

finish off workloads

d626da2

tidying up

850721b

richard-cox added 11 commits December 18, 2024 15:27

tidyuing up imports in hope to fix ts error in check-plugins gate

aa73f3d

Merge remote-tracking branch 'upstream/master' into pagination-cluste…

7e4ee6a

…r-explorer

Merge remote-tracking branch 'upstream/master' into pagination-cluste…

dca2c2e

…r-explorer

tidying up a smidge

595ea90

Many tweaks

e227f3e

- Remove final todo's - includes fix for service type clusterip/headless overlap - Removed ununused ENDPOINT column (note ENDPOINT formatter used in other columns) - Testing freshly added index fields

Improve location of new place where componentWillFetch is set

a9ea060

fix lint, comment updated

dc5a5a3

Fix failing e2e tests

00db7c9

WIP

11eda66

Remove ununused component, tweaks, update ResourceTabs events to be s…

cb87aa3

…uper ok

richard-cox added the ci/skip-e2e Forcibly skip E2E tests in the CI label Jan 7, 2025

richard-cox added this to the v2.11.0 milestone Jan 7, 2025

richard-cox self-assigned this Jan 7, 2025

richard-cox added 5 commits January 8, 2025 11:42

wip

f589ccf

Merge remote-tracking branch 'upstream/master' into pagination-remove…

05eabe9

…-findall-1

Finish off questions/reference

92430b3

Namespace detail - workloads list

31b3bd7

Update ingress detail and edit pages

17778da

- use common helper - both require services and secrets (of type cert) in a specific namespace - for ease, just use the existing mechanism

richard-cox force-pushed the pagination-remove-findall-1 branch from d97fa13 to 17778da Compare January 8, 2025 17:43

tidying up ready for review

fb203f9

richard-cox commented Jan 9, 2025

View reviewed changes

Tidying up ready to review

86ae345

richard-cox removed the ci/skip-e2e Forcibly skip E2E tests in the CI label Jan 9, 2025

richard-cox changed the title ~~Remove usages of findAll for core, non-rbac related resources in cluster explorer view~~ Remove usages of findAll for core resources in cluster explorer view Jan 9, 2025

richard-cox changed the title ~~Remove usages of findAll for core resources in cluster explorer view~~ Remove usages of findAll for core resources in cluster explorer view - 1 Jan 9, 2025

richard-cox mentioned this pull request Jan 9, 2025

Cluster Explorer: Restrict / Remove usages of findAll: traditional types #13025

Open

7 tasks

richard-cox closed this Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove usages of findAll for core resources in cluster explorer view - 1 #13006

Remove usages of findAll for core resources in cluster explorer view - 1 #13006

richard-cox commented Jan 7, 2025 •

edited

Loading

richard-cox Jan 9, 2025

richard-cox Jan 9, 2025

richard-cox commented Jan 13, 2025

Remove usages of findAll for core resources in cluster explorer view - 1 #13006

Remove usages of findAll for core resources in cluster explorer view - 1 #13006

Conversation

richard-cox commented Jan 7, 2025 • edited Loading

Summary

Occurred changes and/or fixed issues

Areas or cases that should be tested

Areas which could experience regressions

Checklist

richard-cox Jan 9, 2025

Choose a reason for hiding this comment

richard-cox Jan 9, 2025

Choose a reason for hiding this comment

richard-cox commented Jan 13, 2025

richard-cox commented Jan 7, 2025 •

edited

Loading